Skip to content

feat: submit run with arguments #1618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
maxy-shpfy merged 1 commit into from
Jan 15, 2026
Merged

feat: submit run with arguments #1618

maxy-shpfy merged 1 commit into from
Jan 15, 2026

Conversation

@maxy-shpfy
Copy link
Collaborator

@maxy-shpfy maxy-shpfy commented Jan 13, 2026 •
edited
Loading

Description

Closes https://github.com/Shopify/oasis-frontend/issues/417

Added the ability to submit pipeline runs with custom arguments through a new dialog interface. This enhancement allows users to customize input values before submitting a run, providing more flexibility when working with configurable pipelines.

Type of Change

  • New feature
  • Improvement

Checklist

  • I have tested this does not break current pipelines / runs functionality
  • I have tested the changes on staging

Test Instructions

Screen Recording 2026-01-12 at 5.06.02 PM.mov (uploaded via Graphite)

  1. Open a pipeline with configurable inputs
  2. Click the new cog icon next to the submit button
  3. Modify input values in the dialog
  4. Submit the run and verify the custom arguments are applied

Additional Comments

This feature enhances the user experience by allowing runtime customization of pipeline inputs without modifying the original pipeline definition.

This was referenced Jan 13, 2026
Merged
Merged
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
@maxy-shpfy maxy-shpfy marked this pull request as ready for review January 13, 2026 01:08
@maxy-shpfy maxy-shpfy requested a review from a team as a code owner January 13, 2026 01:08
This was referenced Jan 13, 2026
Merged
Merged
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from b99e8dd to 94305c9 Compare January 13, 2026 17:51
@maxy-shpfy maxy-shpfy mentioned this pull request Jan 13, 2026
Merged
4 tasks
camielvs
camielvs reviewed Jan 13, 2026
View reviewed changes
camielvs
camielvs reviewed Jan 13, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

There could be a bit of room to improve UX (e.g. a reset to default button, grouping input fields by Task Name) but I think we can iterate on that later.

One small nit I noticed is that I can clear a field that is marked as required. It will show the default value as placeholder and pass that in, which is fine. But given it's a required field it feels weird to be able to "submit" an empty input field. Maybe it should show a warning that the default value will be used?

@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 13, 2026

@camielvs

Maybe it should show a warning that the default value will be used?

Since the placeholder is visible, I think it is sufficient - I would avoid additional UI at least in this PR.

There could be a bit of room to improve UX (e.g. a reset to default button, grouping input fields by Task Name) but I think we can iterate on that later.

Agreed.

@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 94305c9 to 3414ae9 Compare January 14, 2026 00:39
@maxy-shpfy maxy-shpfy requested a review from camielvs January 14, 2026 00:41
camielvs
camielvs approved these changes Jan 14, 2026
View reviewed changes
Copy link
Collaborator

@camielvs camielvs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxy-shpfy maxy-shpfy force-pushed the 01-12-fix_call_rerun_pipeline_with_actual_task_arguments branch from 3723675 to 63662e6 Compare January 15, 2026 02:51
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 3414ae9 to 8040212 Compare January 15, 2026 02:52
@maxy-shpfy maxy-shpfy force-pushed the 01-12-fix_call_rerun_pipeline_with_actual_task_arguments branch 2 times, most recently from e1fb7ff to a43e156 Compare January 15, 2026 08:15
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 8040212 to 422cc17 Compare January 15, 2026 08:15
@maxy-shpfy maxy-shpfy changed the base branch from 01-12-fix_call_rerun_pipeline_with_actual_task_arguments to graphite-base/1618 January 15, 2026 08:18
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from 422cc17 to a045528 Compare January 15, 2026 08:18
@graphite-app graphite-app bot changed the base branch from graphite-base/1618 to master January 15, 2026 08:19
@maxy-shpfy maxy-shpfy force-pushed the 01-12-feat_submit_run_with_arguments branch from a045528 to 314711f Compare January 15, 2026 08:19
@maxy-shpfy Graphite App
Copy link
Collaborator Author

maxy-shpfy commented Jan 15, 2026 •
edited
Loading

Merge activity

  • Jan 15, 8:22 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 15, 8:22 AM UTC: @maxy-shpfy merged this pull request with Graphite.

@maxy-shpfy maxy-shpfy merged commit 87e686e into master Jan 15, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camielvs camielvs camielvs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@maxy-shpfy @camielvs